Dev Feed

PullRequestReviewEvent

I think the updated text makes it clearer what the default behaviour is. For me this is unexpected. I would expect the timeout to stop query execution to protect the database so I think this is worth being explicit about.

Separate non-blocking comment for this PR: - What governs the `PG+MY only` badge in the `#### timeout` header? I can't see it in the markdown. <img width="747" height="257" alt="Image" src="https://github.com/user-attachments/assets/ebb2b6b7-4f60-423a-b5da-2abc929512e5" /> That seems incorrect according to the test cases: https://github.com/rubengmurray/knex/blob/e714ae0df910b0250bdec9f2e2ccb117c7101699/test/integration2/query/misc/additional.spec.js#L769 `TimeoutError` there works for: `Cockroach DB`, `Postgres`, `MySQL`, `MSSQL` & `Oracle`.

PullRequestReviewEvent

Got you. Misread from me. That's what you get for reviewing on a phone!

So then, is there anyone who is against the idea of merging a PR to update the README? Is anyone still around who has the rights to do that? cc @blakeembrey @cspotcode It also feels like we're in the territory of marking the npm package itself as deprecated...? https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions At least these would be fairly trivial changes, and would flag to developers to use something else.

Just came across this as a requirement in one of our features and we've had to use raw. +1 on this. Could potentially look at myself at some point.

Yes, happy to take some time to raise the PR. Will try and get something proposed this week.

Got you. Good to hear.

Hi, Is this package effectively now abandonware? I note @evanshortiss comment here indicates that https://github.com/evanshortiss/env-var/issues/156#issuecomment-2371089961 With 500k downloads a week this seems a real shame. Are people using more widely adopted alternatives?

**Is your feature request related to a problem? Please describe.** Surprised to not find a Date / DateISOString validator in this package. Has it been considered? Feels like it could be quite simple to implement. **Describe the solution you'd like** - asDateISOString() method. - Validates it. If it's not, fails fast and loud. **Describe alternatives you've considered** - Custom validation after env-var usage, but that needs to be hand-cranked.

PullRequestReviewEvent

Do we need to replace nanoid here?

Looks like a good change to me

> Seems like a general AWS SDK issue in Lambda only. > > We get this for SecretsManager SDK. > > AI tooling recommends moving the instantiation inside the execution context, but that hasn't worked, which is very weird - that signals some underlying cache behaviour that we can't control outside of the execution context? > > None of our latency logs point to any kind of delay even close to 5 minutes: I'm working on high throughput, fast acting lambdas by design ~10-100ms. > > This is contributing about ~4,000 errors a week across our ecosystem out the moment. A real noise issue. We found the issue actually: it was a Datadog agent / dependency in our lambdas. We updated the setup and the errors disappeared. We're not getting these errors now with a standard SDK V3 setup instantiated outside of execution context.